Skip to content

feat: add MiniMax AI provider support (fixes #8818) #8819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add MiniMax AI provider support (fixes #8818) #8819

wants to merge 2 commits into from

Conversation

@roomote
Copy link

@roomote roomote bot commented Oct 25, 2025 •
edited by ellipsis-dev bot
Loading

Description

This PR adds support for the MiniMax AI provider to RooCode, implementing the MiniMax-M2 models for coding, reasoning, and AI-assisted development tasks as requested in #8818.

Changes

  • Type Definitions: Added MiniMax provider type definitions with three model variants:

    • : Base model with 128K context window
    • : Pro model with 245K context window
    • : Vision model with 245K context window and image support

  • API Handler: Implemented extending for OpenAI-compatible API integration

  • Provider Configuration:

    • Added MiniMax to provider settings schema
    • Integrated with provider factory and validation
    • Configured default base URL as https://api.minimaxi.com/v1

  • Testing: Added comprehensive test coverage with 15 test cases covering all model variants and edge cases

Testing

  • ✅ All unit tests passing
  • ✅ Linting and type checking pass
  • ✅ Code review completed with high confidence

Related Issue

Fixes #8818

Notes

The implementation follows existing provider patterns in the codebase, particularly similar to the DeepSeek provider implementation. The MiniMax provider uses OpenAI-compatible API format, making integration straightforward.

Important

Adds support for MiniMax AI provider with model definitions, API handler, and comprehensive tests, integrating it into the existing provider framework.

  • Behavior:
    • Adds MiniMax AI provider support with three model variants: Base, Pro, and Vision.
    • Implements MiniMaxHandler in minimax.ts for OpenAI-compatible API integration.
    • Configures default base URL as https://api.minimaxi.com/v1.
  • Provider Configuration:
    • Adds MiniMax to provider-settings.ts schema and integrates with provider factory.
    • Updates ProfileValidator.ts to handle MiniMax provider.
  • Testing:
    • Adds minimax.spec.ts with 15 test cases covering all model variants and edge cases.
  • Misc:
    • Updates index.ts files to export MiniMaxHandler and include it in buildApiHandler().

This description was created by Ellipsis for 8653a05. You can customize this summary. It will automatically update as commits are pushed.

@roomote
feat: add MiniMax AI provider support
627e98a 
- Add MiniMax type definitions with models abab5.5s-chat, abab6.5s-chat, and abab6.5g-chat
- Implement MiniMaxHandler extending OpenAiHandler for API compatibility
- Add MiniMax to provider settings schema and validations
- Include comprehensive test coverage for MiniMax provider
- Support MiniMax-M2 models for coding, reasoning, and AI-assisted development tasks
@roomote
fix: remove unused MINIMAX_DEFAULT_TEMPERATURE constant
8653a05
@roomote roomote bot requested review from cte, jr and mrubens as code owners October 25, 2025 08:36
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Oct 25, 2025
@roomote
Copy link
Author

roomote bot commented Oct 25, 2025 •
edited
Loading

✅ Review Complete - No Issues Found

I've completed a thorough review of this pull request and found no issues that need to be addressed. The implementation:

  • Correctly follows the established pattern for adding OpenAI-compatible providers (matches DeepSeek, Doubao, Moonshot patterns)
  • Properly integrates with all necessary configuration files and validation logic
  • Includes comprehensive test coverage (15 test cases covering all model variants and edge cases)
  • Uses appropriate model configurations (context windows, pricing, capabilities)
  • Has clean, maintainable code that follows project conventions

The MiniMax provider integration is ready for merge.

Follow Along on Roo Code Cloud

@roomote roomote bot mentioned this pull request Oct 25, 2025
Open
2 tasks
roomote[bot]
roomote bot commented Oct 25, 2025
View reviewed changes
Copy link
Author

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Oct 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrubens mrubens Awaiting requested review from mrubens mrubens is a code owner

@cte cte Awaiting requested review from cte cte is a code owner

@jr jr Awaiting requested review from jr jr is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Roo Code Roadmap
Status: Triage

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Add MiniMax AI provider

2 participants

@hannesrudolph @roomote